search

ebean-orm-tools / ebean-gradle-plugin

Plugin that performs Enhancement (entity, transactional, query bean) and can generate query beans from entity beans written in Kotlin via kapt
Apache License 2.0
10 stars 12 forks source link

Delegate annotation processing to gradle #28

Closed soberich closed 5 years ago

soberich commented 5 years ago

This is really a better way to do than https://github.com/ebean-orm-tools/ebean-gradle-plugin/pull/27. Whether you accept or not this one - the previous is quiet essential, as now ebean-gradle-plugin breaks annotation processing for us.

If you use framework like Micronaut and Lombok at the same time it is necessary that Lombok runs before Micronaut processors. See in Micronaut docs. The same applies to querybean generation.

While querybean-generator run behind Gradle ordering it led us to broken compilation.

rbygrave commented 5 years ago

Right, so if I understand correctly ... we should take this PR and close #27 This all seems reasonable and makes things more explicit as I see it.

rbygrave commented 5 years ago

Thanks for this, I think this is a good improvement. Not sure about older gradle versions but this looks like the right thing to do going forward.

Cheers, Rob.