search

ebean-orm / ebean-migration

DB Migration runner (similar to Flyway) which can be used standalone or with Ebean (run migrations on EbeanServer start)
Apache License 2.0
9 stars 5 forks source link

Suggested logging, if version string contains illegal characters #42

Closed rPraml closed 6 years ago

rPraml commented 6 years ago

Hello Rob, I am not confirm with the current implementation. If there is junk in the version number, the ordering is no longer deterministic (We had the concrete issue that we accidently have named one migration script to "1.2a")

I would suggest that the migration should log a warning if this is the case.

I also think, that the version 1.1.2-SNAPSHOT > 1.1.2 (which are currently treated as equal)