Closed rPraml closed 5 years ago
@rbygrave before you merge this, do you think it would be ok/better to use the io.ebean.DDL
logger here, instead of the MigrationTable
logger?
ok/better to use the io.ebean.DDL logger here ?
That is a good point. I think the answer is yes, it would be better to use io.ebean.DDL.
That is a good point. I think the answer is yes, it would be better to use io.ebean.DDL.
I was thinking which would be the best:
The MigrationTable may produce the following log statements, that are all DDL related, so I decided to change the logger in MigrationTable.
logger.error("Migration {} requires prior migration {} which has not been run", localVersion.getVersion(), prior.getVersion());
logger.info("patch migration - insert into history {}", local.getLocation());
logger.trace("... skip unchanged migration {}", local.getLocation());
logger.info("patch migration - reset checksum on {}", local.getLocation());
logger.debug("run migration {}", local.getLocation());
logger.info("Executing jdbc migration version: {} - {}", local.getVersion(), migration);
logger.debug("migration skipped by dbInitVersion {}", dbInitVersion);
I decided to change the logger in MigrationTable.
Yes, good call !!
When a JDBC migration is executed, this should also be logged.
Output is now