search

ebeaufay / threedtiles

3DTiles viewer for three.js
MIT License
270 stars 32 forks source link

Method to chech tile is ready seems not working properly with Google 3D tiles #23

Closed hsonguk closed 6 months ago

hsonguk commented 6 months ago

Thanks for the great work. @ebeaufay

I find tiles cannot load correctly in some area with Google 3D tiles.

For example, using your Ultra Globe example, if I move to Eifel Tower in France.

It seems down to when checking child tiles isReady, it hit the case that the Tile does not have children, no meshcontent and material visibility is False. Thus cannot hide the parent tile. Can you shed some light about your inference?

Many thanks.

Snipaste_2024-02-27_09-24-51

ebeaufay commented 6 months ago

Yep, I broke something recently, working on a fix right now

ebeaufay commented 6 months ago

it seems like google made some changes and have empty tiles that this code considers as an unloaded tile but it should be an easy fix

ebeaufay commented 6 months ago

Fixed in 9.2.8

ebeaufay commented 6 months ago

was a bit quick.. better fix in 9.2.9

hsonguk commented 6 months ago

Impressive speed, thanks @ebeaufay.

I tested it and find out that now the tileloader will always call get() function all the time when the aforementioned situation happened. Is there something wrong with my test?

BTW, it is better to hide your google Key from the source file.

Many Thanks.

ebeaufay commented 6 months ago

yeah I always forget the key but I change regenerate it no worries.

I may have made a mistake in the fix, try 9.2.12, should be better