search

ebekker / ACMESharp

An ACME client library and PowerShell client for the .NET platform (Let's Encrypt)
https://pkisharp.github.io/ACMESharp-docs/
1.21k stars 184 forks source link

Basic plumbing for TLS-SNI challenge #295

Closed WouterTinus closed 6 years ago

WouterTinus commented 7 years ago

This adds the minimum amount of plumbing required for TLS-SNI validation. Using these changes I've been able to successfully test TLS-SNI validation in letsencrypt-win-simple, which I'm hoping to release later this year.

My code to answer the TLS-SNI challenge (that builds on this PR) still needs a lot of cleaning up and testing, but I suspect parts of it might end up being useful for the ACMESharp library.

Marcus-L commented 7 years ago

I'm getting an error with the reference to NLog, was there supposed to be a change to the csproj file to add a reference?

WouterTinus commented 7 years ago

The only changes to the .csproj are the two new classes. The logger is literally copy-pasted from the DnsChallengeDecoder. Perhaps you simply have to run a NuGet package restore?

Marcus-L commented 7 years ago

My mistake, I hadn't updated my source in a while. Thanks!

Marcus-L commented 7 years ago

Hi @ebekker - this LGTM but is there any thing we can do for you (requested modifications, answer questions, etc) to get this PR merged?

ebekker commented 6 years ago

Wow, this looks great! I'll be taking a look at this shortly. It looks like the PR has some conflicts, I"m wondering if you guys can take a look at resolving those first?

Marcus-L commented 6 years ago

OK. I think @WouterTinus might have already deleted the branch the PR was made from, I'll start up another PR with the commits rebased on your current master.

ebekker commented 6 years ago

Thanks, it looks like the only conflicting issue was in the .csproj file which is pby because of another PR that I just accepted, and in that case, I'm actually fixing stuff up right now to remove those changes anyway.

ebekker commented 6 years ago

I'm closing this out since it was re-introduced in #308.