search

ebekker / blazor-ag-grid

Blazor-wrapped component over ag-Grid -- demo:
https://blog.bkkr.us/blazor-ag-grid
MIT License
60 stars 18 forks source link

Column Definition attributes #9

Closed jhcorey closed 3 years ago

jhcorey commented 3 years ago

Hello, Thanks for all you have done on this. Right now I am converting an app that was written in Angular to blazor. Some of the columns in our grid such as dates or currency need to be formatted, and in Angular the ColumnDefinitions included attributes such as cellClass and valueFormatter. I don't see these as yet in blazor-ag-grid. Are these implemented as yet?

jhcorey commented 3 years ago

Ah, never mind. Seems easy to simply add the attributes to ColumnDefinition

ebekker commented 3 years ago

Yep, I didn't add all possible attributes, this started off more as a proof-of-concept to demonstrate how to wrap ag-Grid using JSInterop, so there are many features that are not in there. Most are fairly trivial to implement, like you found out, just simply adding the necessary attributes to the existing classes.

I myself "fill them out" as I go along and find features that I need to incorporate in my work, but don't go out of my way to make them complete. But hopefully others who find this valuable will contribute back any changes that they find useful as well.

jhcorey commented 3 years ago

Yes, I’m moving along with adding more attributes, and it’s easy enough.

We are using server-side Blazor and rewriting an Angular app. I have a concern about performance when we actually deploy to a web server. We have reports that typically have a few thousand rows, and we provide the sorting facility. If the sorting happens on the client I guess we should be good.

From: Eugene Bekker [mailto:notifications@github.com] Sent: Friday, November 13, 2020 11:36 AM To: ebekker/blazor-ag-grid blazor-ag-grid@noreply.github.com Cc: James COREY james_corey@tjx.com; Author author@noreply.github.com Subject: [External] Re: [ebekker/blazor-ag-grid] Column Definition attributes (#9)

Yep, I didn't add all possible attributes, this started off more as a proof-of-concept to demonstrate how to wrap ag-Grid using JSInterop, so there are many features that are not in there. Most are fairly trivial to implement, like you found out, just simply adding the necessary attributes to the existing classes.

I myself "fill them out" as I go along and find features that I need to incorporate in my work, but don't go out of my way to make them complete. But hopefully others who find this valuable will contribute back any changes that they find useful as well.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/ebekker/blazor-ag-grid/issues/9*issuecomment-726864684__;Iw!!GahIEkFg!me8GzYr7mR9QPS0xvtJZZ6y-knvIJkTXpdKsIFYc72VwVp7R9S0Ef730__F71rBC$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AIIVSRDFZVDG7QM2VN7RSOLSPVN7XANCNFSM4TT3PRAQ__;!!GahIEkFg!me8GzYr7mR9QPS0xvtJZZ6y-knvIJkTXpdKsIFYc72VwVp7R9S0Ef730_3htYtCZ$.