search

ebellocchia / bip_utils

Generation of mnemonics, seeds, private/public keys and addresses for different types of cryptocurrencies
MIT License
292 stars 83 forks source link

Creating P2SH Addresses for Networks Without SegWit Support #117

Open mrtnetwork opened 7 months ago

mrtnetwork commented 7 months ago

I generated a BCH address using the BchP2SHAddrEncoderon the BCH testnet for testing purposes. Despite multiple attempts, I could not initiate a payment from this address. Subsequently, I created another address for this network, this time using the P2SHtype but with a different script (p2sh-p2pk,p2sh-p2pkh, and the standard p2shmultisig address). Fortunately, I was able to spend from the newly created address. During my research, I stumbled upon this post:. I believe that a different script should be employed to generate P2SHaddresses for networks that don't support SegWit, such as BCH, DASH, and DOGE. I'm not entirely sure and would appreciate it if you could confirm. Thanks.

I want to express my gratitude for the excellent package you have created. I extensively used your package code to develop a wallet package in Dart.

ebellocchia commented 6 months ago

Hi, thanks and sorry for the late reply. I'll take a look into it, even if I remember the addresses were correctly generated.