ebenmichael / augsynth

Augmented Synthetic Control Method
MIT License
148 stars 52 forks source link

`fit_prog_gsynth` transformations aren't saved back to variables #107

Open jntrcs opened 1 month ago

jntrcs commented 1 month ago

fit_prog_gsynth attempts to transform two variables to numeric. However, because the transformations are not saved to df_long, they have no end effect and the function continues on with character vectors instead of numeric vectors.

https://github.com/ebenmichael/augsynth/blob/664c0c7aa818aa91639215552d9682ba1e88d1d8/R/outcome_models.R#L198

(Also, FWIW, the documentation for transform warns against using it in anything other than interactive use)