ebenmichael / augsynth

Augmented Synthetic Control Method
MIT License
147 stars 52 forks source link

Combine into one entry point for the API #14

Closed ebenmichael closed 4 years ago

ebenmichael commented 5 years ago

There are two different estimators based on the data type:

  1. augsynth: for cases where there is one treated unit or multiple treated units with one treatment time.
  2. multisynth: for cases where there are multiple treated units across multiple distinct treatment times.

We should try to combine these functions into one augsynth function that checks whether there are multiple treatment times or not and then acts accordingly, maybe just by calling one of those two functions. Both of these functions create two different classes, so we might want to create a parent class and have these two classes as child classes.

One hing that would be nice to get rid of is the need to specify the treatment time t_int.

ebenmichael commented 4 years ago

Closed by #15