search

eberlitz / splashicon-generator

Automatic Icon and Splash resizing for Cordova based projects
MIT License
101 stars 43 forks source link

Missing some @3x icons for iPhone 6 Plus #25

Closed dharders closed 8 years ago

dharders commented 8 years ago

I found when using cordova with an iOS target platform and testing with my iPhone 6 plus, the default cordova icon would show up when a 'double tap' of the home button occurs. All other icons seem to work (i.e. Home icon, Search/Spotlight etc).

I used your config.xml as stated in your docs.

Not sure if this is strictly an iPhone 6+ issue or iOS 9+ issue, either way, I have solved it below.

I fixed my issue by modifying index.js #L33-L48 to add a -3x for all icons and increased the respective size:

I also updated config.xml to point to these new files.

Please update the repo so other iPhone 6+ users don't run into the same issue.

Thanks again for creating such a handy tool!

pke commented 8 years ago

Care to submit a PR with your changes?

dharders commented 8 years ago

@pke I'll see what I can do later this week...pretty swamped with work currently!

dharders commented 8 years ago

@pke Fixed in #26

pke commented 8 years ago

Great. Thanks!

dharders commented 8 years ago

@eberlitz good to close this issue, since merged. Or wait for npm release ?

eberlitz commented 8 years ago

Hi, thanks for your work. I just validate the sizes with the Apple docs and removed the unused ones to not increase the size of the app without need.

Also included the new splash sizes for the iPad Pro 12.9".

Released under npm as 0.2.10;