search

eberlitz / splashicon-generator

Automatic Icon and Splash resizing for Cordova based projects
MIT License
101 stars 43 forks source link

Use lwip instead of imagemagick #27

Closed pke closed 4 years ago

pke commented 8 years ago

~~I wonder what you think about using SVGs as source images for icons and splash? That would eliminate the need for big PNGs and "save areas" as SVGs can be scaled very well. edit Hmmm. I just see that lwip does not support loading SVG atm :(~~

What about using https://www.npmjs.com/package/lwip instead of imagemagick? Its lightweight, doesn't need no installation on any platform (would come as a dependency of this package).

eberlitz commented 8 years ago

My intentions was to change to GraphicsMagick. But I will check this lwip.

pke commented 8 years ago

Anything that reduces external dependencies would be fine :)

peterschmidler commented 8 years ago

also, the imagemagick module seems abandoned, throws ugly "resize arg" console.logs and fails on some machines with an "Error: spawn convert ENOENT" error...

pke commented 8 years ago

aha. I already wondered where those "resize arg" output originated from. Yeah, I think reducing one dependency would be a nice effort.

I also thought if it would be possible, when using SVG as the input, to actually be able to have text in them and with SVG/CSS to position this text. That would allow us to get rid of the "safe-areas" and the rendered PNG output would always look great on all resolutions.

pke commented 8 years ago

And by the way, we could also support SVG as the source format: https://github.com/domenic/svg2png

lcaprini commented 7 years ago

@pke @peterschmidler In my fork I removed ImageMagick and I'm using GraphicsMagick; same code and same functionalities. Here the PR: https://github.com/eberlitz/splashicon-generator/pull/45.

-L