search

eberthold / SteroidsVS

Visual Studio Extension
https://marketplace.visualstudio.com/items?itemName=eberthold.SteroidsVS
MIT License
25 stars 2 forks source link

Latest commit caused backspace to stop working in some cases. #12

Closed pushqrdx closed 5 years ago

pushqrdx commented 5 years ago

The latest commit creates a strange behavior where Delete or Backspace keys aren't working after adding multiple diagnostics. I made sure that it's the latest commit because the one before it didn't make that issue.

Reproduction:

You can't then use backspace or delete anywhere in the file.

eberthold commented 5 years ago

I'm aware of this problem which I introduced while trying to finish #5 and #9. That's why the latest commits never made it past pre-release.

I will rollback master to the latest working state. The last commit is obsolete anyway, because I'm currently rewriting most of that keyboard handling logic.

Update: I decided to cherry pick your PR to release branch and try to complete fix keyboard handling soon as possible.

eberthold commented 5 years ago

I just merged #16 which fixes this broken behavior. The keyboard/mouse handling is not complete at this point but should be a base to develop other features without struggling with that specific bug