search

ebertolazzi / Clothoids

BSD 2-Clause "Simplified" License
106 stars 51 forks source link

G2solve3arc::curvatureMinMax() error #1

Closed sts-thm closed 5 years ago

sts-thm commented 6 years ago

In the implementation of G2solve3arc::curvatureMinMax(): https://github.com/ebertolazzi/Clothoids/blob/3a8f037bc01e0c53cb13b4b217e1bb8e990a9288/src/ClothoidG2.cc#L766 you compute the minimal and maximal values for theta instead of the extrema of the curvature. I think the right implementation would be to exchange S0.thetaMinMax() with S0.curvatureMinMax() and analogously for S1 and SM in the lines 768, 769 and 772.

ebertolazzi commented 6 years ago

thanks for the reporting, I changed the code removing the error.