4.0 version many bugs

[stepanenko3]

I use Nova 4.2.2

• If I add media and then open the editing form again, the media is not shown
• Bugs below

[mucenica-bogdan]

Thanks for reporting, working on the issues now, will create a PR for a patch release in a couple of hours.

[mucenica-bogdan]

Hey @stepanenko3, I started a PR #321 to fix the above.

There is one thing I couldn't replicate: If I add media and then open the editing form again, the media is not shown. Can you give me a screen recording or some more details on how to replicate?

On my end if I:

• upload an image -> update [RESOURCE] -> go back to the edit form of the [RESOURCE] -> I see the image.
• upload an image -> update and continue editing [RESOURCE] -> I see newly uploaded the image.

Also, in the second to last screenshoot, the one with the statistics, I see that on your end you don't get the size of the image. There is an condition (there before the migration to nova4) to only show the size if it comes set from the server.
Is this your reported bug, the missing size?

On my tests I do get the size filled in:

[stepanenko3]

@mucenica-bogdan, I recorded a screen with this problem https://we.tl/t-Zb2zF7Ldg7

But on the index page, the image is displayed The details page displays [object Object]

The same problem for uploaded new images (even when the size is displayed)

[mucenica-bogdan]

@stepanenko3 - thanks for the video. still can't replicate from my end but I'll try to push it some more.

in the meantime, can you try to use the package from my fork by changing your composer.json file and see if it works better from there?

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/mucenica-bogdan/advanced-nova-media-library.git"
        }
    ],
    "require": {
        "ebess/advanced-nova-media-library": "dev-nova-4-bugfix",
    }
}

run composer update after the composer.json file change change.

[stepanenko3]

@mucenica-bogdan The problem still remains

I also noticed a number of bugs:

• "Use Existing Media" is not made by the button
• In the selection modal of existing media images, you need to set object-fit: cover; or object-fit:contain
• No window rounding (like nova 4 design)
• Header without contrast background(for example, select field white on white header)
• Close is not made by the button
• Load Next Page is not made by the button
• The detail page does not show an image(There is no [object Object] now, but there is no image itself either)
• It does not show the added image in the form after the update

My code looks like this:

Images::make('Image', 'image')
    ->conversionOnIndexView('small')
    ->conversionOnDetailView('medium')
    ->conversionOnPreview('medium')
    ->conversionOnForm('small')
    ->setFileName(function ($originalFilename, $extension, $model) {
        return md5($originalFilename) . '.' . $extension;
    })
    ->showDimensions()
    ->enableExistingMedia(),

I using single file field in example

[stepanenko3]

@mucenica-bogdan And of course, a large number of bugs in dark mode

[stepanenko3]

@mucenica-bogdan

• In the crop modal, the actions are not like buttons
• And there is no mobile version
• In customPropertiesFields modal doesn't fit content
• It's not clear whether it's a feature or bug, but the crop button is different from the rest on the thumbnail (delete, edit, download)
• I think it's worth refactor the image selection modal using grid, it will be more correct, and it will be easier to make a mobile version
• "Existing Media" text in the modal window looks like text, but not like a title

See screenshots in Readme.me, it will make it clear what everything should look like But I would add a couple more improvements, such as rounding a modal window, rounding thumbnails in this window Please use all available field types and functions at once, such as one image, many images, one file, many files, a window with additional fields, etc.

[mucenica-bogdan]

Thanks for the info, I'll continue to work on this tomorrow morning.

[mucenica-bogdan]

Hey @stepanenko3, I just pushed a new patch to my fork.

I think I've fixed everything reported above.

The only thing that I couldn't replicate is that missing image after upload issue. I noticed that you are using conversions to show the preview images. Are you doing the conversion in a queue? If so, do you have your queue worker up and running to process the conversions?

[bkintanar]

@mucenica-bogdan thank you for your efforts. I'll check on your changes.

[stepanenko3]

@mucenica-bogdan, @bkintanar

I don't show images on the form page because of this error

[mucenica-bogdan]

can you share with me the image you've uploaded that gives you this error?

[stepanenko3]

fixed in #325