ebess / advanced-nova-media-library

A Laravel Nova field for displaying, creating, updating and ordering a Spatie Media Library model.
591 stars 295 forks source link

Fix issues loading translations #391

Closed leandrogehlen closed 1 year ago

tobias-grasse commented 1 year ago

@bkintanar This looks like a nice addition. Any reasons to not merge this?

As far as I know, all frontend fields use the Vue translation helpers. Loading translations from a vendor-override location would enable users to keep translations for advanced-nova-media-library separate from their other lang files. Giant JSON files tend to become messy string graveyards otherwise 😄 The approach in this PR is similar to how Nova itself does it (vendor/laravel/nova/src/NovaServiceProvider.php::registerResources). I'd suggest using lang_path instead of resource_path('lang/') though, this helper is available in laravel/framework 8.x and up.