detach is now fixed - Githubissues

ebetica / autogradpp

Direct C++ Interface to PyTorch

MIT License

80 stars 12 forks source link

Closed Kaixhin closed 6 years ago

Kaixhin commented 6 years ago

Fixes such comments as:

oh god why is that in there

and

and why did the tests not catch it

It'll never live up to the PR in which Andrej called me a hero, but maybe this comes a close second.

ebetica commented 6 years ago

I don't see the comments in the fixes?

Kaixhin commented 6 years ago

Comments were made offline, and I'm preserving the privacy of the person who made them :P

ebetica commented 6 years ago

Oh I got confused, sorry.