search

ebi-ait / checklist

Template repository for checklists
Apache License 2.0
1 stars 0 forks source link

Tokenise sample error messages on ENA validation #135

Open ESapenaVentura opened 2 weeks ago

ESapenaVentura commented 2 weeks ago

The current sample validation messages are:

ERAM.1.0.30={0} failed validation due to {1}

Where 0 is the sample alias

In order to improve this, we want the error message to change to:

sample:{<sample-name>}; attribute:{<path-to-attribute>}; reason:{<reason>}

In order to do that, the error message that ENA parses needs to be changed.

dipayan1985 commented 2 weeks ago

Hi @ESapenaVentura What about the messages as? sample:{<sample-name>}; attribute:{<attribute_name>}; reason:{<reason>}

I am suggesting this because path-to-attribute or dataPath will not make meaning to an ENA submitter as they are not submitting directly to BioSamples, we are converting their submitted ENA XML or ENA JSON to BioSamples JSON and persisting to BioSamples. The path-to-attribute is relevant for BioSamples only.

ESapenaVentura commented 1 week ago

Sounds good to me - sorry, I missed this message!