ebi-ait / checklist

Template repository for checklists
Apache License 2.0
1 stars 0 forks source link

Units should be converted correctly to JSON Schema #30

Closed theisuru closed 2 weeks ago

theisuru commented 1 month ago

For some fields, units is an enum value that only accepts certain types of units. In the converted JSON schema, units is just defined as "string", with no restriction (See example here)

ENA is right - JSON Schema does not define enums for units, and it should https://github.com/ebi-ait/checklist-converter/blob/main/schema/ERC000052-ENA.json#L366C13-L367C32 in ENA, this is limited to "hours,weeks,minutes,days,years" SAMEA7025236 ERC000052