ebi-ait / checklist

Template repository for checklists
Apache License 2.0
1 stars 0 forks source link

remove validation of xml checklists from ENA #59

Closed amnonkhen closed 1 month ago

amnonkhen commented 3 months ago

This task is a submission stream task.

DoD:

dipayan1985 commented 3 months ago

The acceptance criterias for replacing XML checklist validation in ENA with JSON schema validation done in BioSamples are as follows:

  1. Behaviour (HIGHEST RISK):

The result of validating a sample document against a XML checklist and its corresponding JSON schema should be the same. If sample SAMEX is valid against a XML checklist it should be valid against the corresponding JSON schema and vice-versa. This is very important and if this fails this move will need to be rolled back until the behaviour is fixed.

  1. Error messages (LOW RISK):

E.g. extra error messages for synonyms etc should be filtered out, if collection_date and geographic_location are mandatory fields and the sample doesn't have those then there should be 2 error messages, 1. collection_date missing, 2. geographic_location missing, text can be different.

  1. Performance (HIGH RISK): The round-robin time of sending a single sample to BioSamples and receiving an accessioned sample is ~70 milliseconds. It is sure to go up by a little bit but we expect the response times to be ~100 milliseconds.