ebi-ait / checklist

Template repository for checklists
Apache License 2.0
1 stars 0 forks source link

Webin:JSON schema tests - case sensitivity of attribute names #79

Closed amnonkhen closed 1 month ago

amnonkhen commented 2 months ago

Checklist: ERC000026 Checklist class: EGA Sample Attribute in question: phonotype Issue: If sample specify Phenotype (P in uppercase) its currently accepted. With JSON schema validation it is not. Impression: trivial issue might need to be communicated with ENA product owner

Part from checklist:

         <FIELD>
          <LABEL>phenotype</LABEL>
          <NAME>phenotype</NAME>
          <DESCRIPTION>Where possible, please use the Experimental Factor Ontology (EFO) to describe your phenotypes.</DESCRIPTION>
          <FIELD_TYPE>
            <TEXT_FIELD/>
          </FIELD_TYPE>
          <MANDATORY>mandatory</MANDATORY>
          <MULTIPLICITY>multiple</MULTIPLICITY>
        </FIELD>

Sample:

<SAMPLE_SET>
    <SAMPLE alias="" center_name="" broker_name="">
        <TITLE>Test Sample</TITLE>
        <SAMPLE_NAME>
            <TAXON_ID>9606</TAXON_ID>
        </SAMPLE_NAME>
        <SAMPLE_ATTRIBUTES>
            <SAMPLE_ATTRIBUTE>
                <TAG>Strain</TAG>
                <VALUE/>
            </SAMPLE_ATTRIBUTE>
            <SAMPLE_ATTRIBUTE>
                <TAG>Sample Description</TAG>
                <VALUE/>
            </SAMPLE_ATTRIBUTE>
            <SAMPLE_ATTRIBUTE>
                <TAG>Gender</TAG>
                <VALUE>Male</VALUE>
            </SAMPLE_ATTRIBUTE>
            <SAMPLE_ATTRIBUTE>
                <TAG>Phenotype</TAG>
                <VALUE>Not Applicable</VALUE>
            </SAMPLE_ATTRIBUTE>
            <SAMPLE_ATTRIBUTE>
                <TAG>Donor Id</TAG>
                <VALUE>IBD_UC5147362</VALUE>
            </SAMPLE_ATTRIBUTE>
            <SAMPLE_ATTRIBUTE>
                <TAG>ENA-CHECKLIST</TAG>
                <VALUE>ERC000026</VALUE>
            </SAMPLE_ATTRIBUTE>
            <SAMPLE_ATTRIBUTE>
                <TAG>geographic location (country and/or sea)</TAG>
                <VALUE>South Africa</VALUE>
            </SAMPLE_ATTRIBUTE>
            <SAMPLE_ATTRIBUTE>
                <TAG>collection date</TAG>
                <VALUE>2019</VALUE>
            </SAMPLE_ATTRIBUTE>
        </SAMPLE_ATTRIBUTES>
    </SAMPLE>
</SAMPLE_SET>

Error:

10:00:16.214 [Test worker] ERROR uk.ac.ebi.ena.sra.SubmitTest - 03924959-c5b9-4f7e-947c-1adef284ff85 failed validation due to Just one of the following properties must be specified: 'phenotype'
Jeena-Rajan commented 1 month ago

Spoke to Colman, this checklist is being actively used but recent submitters have used lowercase 'phenotype'. Colman has agreed JSON validation behaviour of only accepting lowercase value is fine. Nothing to do here.