Closed gabsie closed 3 years ago
Hi, @jacobwindsor and @mshadbolt
Attaching here one idea to show:
I will also upload two more ideas..
Gabs
Wanted to note down currently where publications have come from:
@gabsie just confirming that there's nothing I can work on right now right?
Also, about the pagination, there's none at the moment. Would you rather have some rather than one long table?
@jacobwindsor
I wonder if today we can at least, from this screenshot, work on:
I will think what else? and let me know if questions!!! Gabs
I think I am a bit confused, wouldn't adding the footer from the ingest ui not be compliant with what the footer needs to look like for ebi resources?
I am also not sure on pagination...
I'm also not sure it's a good idea to link to pages that don't exist. It's looking like this will go into production very soon and I can't see those three pages content getting made this week
@mshadbolt - maybe we can catch up with Tony on the footer. Are we presenting this Catalogue as within the EMBL-EBI resources? In which case it will have to have the usual EBI footer..?
@jacobwindsor - OK on the top pages... but maybe we need to create tickets for content on the About page.. @mshadbolt
@gabsie i assume so, given it is at an ebi address...
@gabsie as this is being presented under ebi.ac.uk it has to have the EBI footer and follow EBI style/visual framework
@lauraclarke @tburdett So an important question here:
I will get in touch with VF to see what is the current way to feature header and footer meanwhile.
Actually, it would be a good idea for @mshadbolt @tburdett and @lauraclarke to list here comments on the design above.. Any feedback is welcome.
Gabs
I think the GWAS catalog is a special case. I don't think there are many or any other examples where if you are under ebi.ac.uk and you don't have to had the standard header/footer
This is meant to be an EBI resource so making it look like all other EBI resources makes sense
@jacobwindsor Hey, @jacobwindsor - seems the current and most up-to-date way to include EMBL-EBI header and footer is here: https://stable.visual-framework.dev/components/ebi-header-footer/ And a sample page: https://stable.visual-framework.dev/patterns/boilerplate-generic-embl-ebi/
Let's try this out, and I can meanwhile see how to integrate the table of projects inside. Please let me know if comments or questions!
Gabby.
@gabsie the index already includes one of the EBI footers but I will update to your preferred one. Your design does not include the header, do you want that? The page already has the cookie notice
Hey @jacobwindsor - yes let's go ahead with the header (meaning only the top strip with the EMBL-EBI navigation etc) and see how everything looks. I will try update the inside of all this at some point as well :)
On the specific question for me:
is this Project Catalogue being presented as part of EMBL-EBI? (where you imagine the EMBL-EBI top nav and footer, like on Arrayexpress and eqTL catalogue: https://www.ebi.ac.uk/arrayexpress/browse.html )
Yes to this position. This is an EMBL-EBI service that is a complementary resource to the DCP. This means it is a requirement to use EMBL-EBI styling (and headers and footers, etc) on the pages for consistency with other EBI web content.
Hey, @jacobwindsor and @mshadbolt
Attaching the updated design here as well. Now that we have the EMBL-EBI header and footer, we don't need to repeat the EMBL logo (it's part of the Header)
I am here for questions/discussion right after 1pm.
Gabs
@gabsie is there anything I can do to help with coming up with the explanatory text for this or are you on it?
I have updated the ticket name, I think since we decided that we will now have 'about' information as a separate page, we need a design about what that page should look like. The existing designs in this thread show what the link to this page will look like from the catalogue page, i.e. a link from the top right corner. I think we decided we don't yet need a 'Contribute a project' or 'Contact' page
HI, @mshadbolt AND @jacobwindsor
I actually reviewed the new visual framework for boilerplates and I think we can use that for our About page. see here: https://chanzuckerberg.invisionapp.com/console/share/F7ZY8J9TEZ4/516301155
and... , I think we can maybe also use the same boilerplate for our homepage eventually, because the current thing is not very well organised (done as an MVP and quickly... as always)
And you can view a similar boilerplate here: https://stable.visual-framework.dev/patterns/boilerplate-generic-embl-ebi/ but this one as well is a good example:
http://wwwdev.ebi.ac.uk/training-beta/about
Please let me know any concerns.. :) I am free for a chat till 1. I might need to find a background image that fits the HCA, if we go this way.
Gabs
thanks @gabsie
Just reviewing https://chanzuckerberg.invisionapp.com/console/share/F7ZY8J9TEZ4/516301155
I am slightly concerned about the use of the word All in this sentence
All datasets identified as suitable for the HCA by the HCA Data Coordination Platform wranglers
Could we lose All, I worry that that word might make people think if their dataset which has to existed for a while isn't on the list it is because it was assessed as non-suitable rather than because we either didn't know about it or haven't got round to adding it yet
@lauraclarke I understand your concern here but rather than softening the aims by removing the "all" (creating ambiguity around what we aim to include), it would be better to use this as an opportunity to encourage people to reach out if they think something is omitted (indeed the bottom line does just this, but could maybe be more prominent)
Hi, @jacobwindsor and @mshadbolt
So I have attached a simple version of the About, without using the boilerplate, and a version with using the boilerplate from VF. Both are with breadcrumb at the top, which hopefully will give people a way back to catalogue (a link at the bottom as well)
Maybe at this stage go with the one without.
@tburdett and @lauraclarke - I have commented on the separate issue about the content,
Gabs
User story: As a single cell researcher interested in HCA relevant data, I want to understand the source and selection of the projects on this page, so that I know how they differ to other similar resources or if there's an overlap.