search

ebi-ait / dcp-ingest-central

Central point of access for the Ingestion Service of the HCA DCP
Apache License 2.0
0 stars 0 forks source link

suggest a project #360

Closed amnonkhen closed 3 years ago

amnonkhen commented 3 years ago

see https://docs.google.com/document/d/1fSIPU85oDj_Ee09zyyHegHJwwy66vN-cGgn12hJC1B4/edit

clairerye commented 3 years ago

Form that alerts wranglers in some way when the form has completed and its contents so a wrangler can review it contains: Name contact email address DOI/URL Optional Free text for additional comments

clairerye commented 3 years ago

possible dependency in #313

MightyAx commented 3 years ago

Implementation Idea: Unsecured Post/Get endpoint on ingest-core that puts the project in the database but not in the catalogue with a wrangler status that allows them to find it.

new project with just:

Something we discussed was using the uniqueness check on doi to reject doi's those already exist in ingest, with nice error messages, for example:

If this implementation path is chosen we need to also add in #313 (or a dedicated page for listing New projects) so that the wranglers can triage and assign new projects suggested from the catalogue so that they can be reviewed for Eligibility.

clairerye commented 3 years ago

If we are collecting the persons name and email could we also add that into the notes section on the admin page? (this is a nice to have! not essential so happy for it to be out of scope for now.)

clairerye commented 3 years ago

need to consider GDPR and terms and conditions for this

gabsie commented 3 years ago

Hi, @jacobwindsor and @MightyAx

Attached the suggested form for suggesting a project, I am only now doing the Thank you page, and will upload it here as well. Please ask me questions. (Updated the file, after Claire's comment)

Suggest a project.png

https://www.figma.com/proto/Ajxve72idcWGOB07GKy8pC/HCA-ingest-Master?page-id=0%3A15981&node-id=597%3A12&viewport=-13392%2C-2338%2C0.30283689498901367&scaling=min-zoom

Gabs

clairerye commented 3 years ago

Can we have a tick box terms and conditions please - link is: https://www.ebi.ac.uk/data-protection/privacy-notice/human-cell-atlas-ingest-submission maybe just above the send button? @gabsie

gabsie commented 3 years ago

Yes, just updated the image! Sorry And here is the Thank you page as well.![Suggest a project-thanks.png]Suggest a project-thanks.png

clairerye commented 3 years ago

They look awesome, thank you!

MightyAx commented 3 years ago

Ah, I don't think I understood what a Project URL is and why it's a good substitute for Publication DOI. Is this so we can take pre-publication info?

clairerye commented 3 years ago

I wanted to make it more flexible than simply a publication DOI, so people could use archive URLs, bioarchive URLs (which mostly but not always have a doi) their own website like the covid19 portal etc- lots of which was pre publication. Sounds like we need to change the wording or we perhaps need some examples after it to make that more obvious?

MightyAx commented 3 years ago

I think it just means we can't automatically put it through the DOI Enrichment routine we use for the UI / Script Loading. But perhaps that wasn't ever a requirement.

gabsie commented 3 years ago

hey @jacobwindsor

I entered my details but it deosn't allow me to submit, while on the surface everything should be correct (using a real DOIScreenshot 2021-06-25 at 16.31.02.png)

gabsie commented 3 years ago

changed my email to not be all caps worked. but the all caps one was from my remembered info