ebi-ait / dcp-ingest-central

Central point of access for the Ingestion Service of the HCA DCP
Apache License 2.0
0 stars 0 forks source link

Unable to un-assign primary or secondary wrangler #620

Closed ipediez closed 2 years ago

ipediez commented 2 years ago

Description of the task:

The project Multiomics single-cell analysis of human pancreatic islets reveals novel cellular states in health and type 1 diabetes is not wrangleable right now, as it is a pre-print with no data or metadata available at the moment. To avoid this affecting our way of filtering and triaging datasets in Ingest, it would be great to set back the value of the "Primary Wrangler" field to its default. This cannot be done from the UI, where the last value of the field gets automatically assigned when left blank, so a dev action is needed.

Acceptance criteria for the task:

Other fields that can't currently be un-set, should be resolved by current intended solution:

MightyAx commented 2 years ago

Reviewer's: @aaclan-ebi & @yusra-haider

MightyAx commented 2 years ago

This issue is 2 fold:

  1. there is no interface (clickable) to allow "clearing a wrangler assignment" or "setting the default value" for primary or secondary wranglers.
  2. The underlying data for an unassigned project is primaryWrangler: null, ingest-ui strips out all null values before sending the data to ingest core.
    • This affects more fields than primary / secondary wrangler and will have to be fixed for those fields too.
MightyAx commented 2 years ago

Work in progress solution for problem 1: "there is no interface (clickable) to allow clearing a wrangler assignment": Screenshot 2022-01-26 at 17 32 05 Screenshot 2022-01-26 at 17 32 20 Screenshot 2022-01-26 at 17 33 13

MightyAx commented 2 years ago

Current Sequence Diagram: https://miro.com/app/board/uXjVOSWgtMw=/

ipediez commented 2 years ago

@gabsie @ipediez and @ofanobilbao to take a look at the design and the functionality

gabsie commented 2 years ago

Hi, @MightyAx - I am good with the designs shown above !

MightyAx commented 2 years ago

@ofanobilbao you wanted to know the other fields that can't currently be un-set, that should be resolved by current intended solution:

MightyAx commented 2 years ago

Awaiting PR Reviews

idazucchi commented 2 years ago

Jacob is reviewing

MightyAx commented 2 years ago

Review comments resolved, merged and deployed to dev. merged to master and deployed to staging. Will sit with @Wkt8 this afternoon to verify.

Wkt8 commented 2 years ago

Have sat with @MightyAx and tested it - looks great. Clear, and fulfils what we are trying to do. I think we can put this into production.

MightyAx commented 2 years ago

Deployed to Production. Verified functionality is on production