search

ebi-ait / dcp-ingest-central

Central point of access for the Ingestion Service of the HCA DCP
Apache License 2.0
0 stars 0 forks source link

When removing "INSDC sample accession" field's value the field got an empty string value #653

Open ke4 opened 2 years ago

ke4 commented 2 years ago

Steps to reproduce:

  1. Go to Ingest UI
  2. Select a submission with Archiving status
  3. Edit one of the biomaterial and remove the value from the INSDC sample accession field
  4. Save the biomaterial
  5. Click on the ingest api url and check the JSON.

Expected behaviour: There should not be a field inside biomaterial_core with a key insdc_sample_accession.

Actual behaviour: There is a field inside biomaterial_core with a key insdc_sample_accession and its value is: "" (an empty string).

The biomaterial also gets a validation error: .biomaterial_core.insdc_sample_accession : should match pattern "^[DES]RS[0-9]+$"

aaclan-ebi commented 2 years ago

to verify if this is the same issue : https://embl-ebi-ait.slack.com/archives/C016R78CDV1/p1644502236844049