ebi-ait / dcp-ingest-central

Central point of access for the Ingestion Service of the HCA DCP
Apache License 2.0
0 stars 0 forks source link

A submission guide section with information for end contributors #717

Closed gabsie closed 1 year ago

gabsie commented 2 years ago

Acceptance Criteria / Definition of Done

Tasks:

gabsie commented 2 years ago

First version of a design (still have to see about the right VF components), but can work as a prototype first. The sizing of the page is also not right yet

Sprint 6 April - Project tab - Submission guide.png

Sprint 6 April - Project tab - Submission guide 2.png

gabsie commented 2 years ago

Hey @jacobwindsor - as a start, please consider these two pages as placeholders for 2 pages from the Submission guide: https://ebi-ait.github.io/hca-ebi-wrangler-central/SOPs/dataset_suitability_SOP.html https://ebi-ait.github.io/hca-ebi-wrangler-central/SOPs/GDPR_Guidelines.html

These two pages will fall under the category of Data requirements, from the first version of the suggested design above. I will have time in the afternoon to chat through this :) Please consider also having a diagram in one of the pages, the Data Policy one will probably have the GDPR diagram in a similar format.

I will later change the copy to be contributor-focused and not wrangler focused, but the overall size and contents should be okay for you to get started.

idazucchi commented 2 years ago

finishing off page layout, the pages will render markdown documents

yusra-haider commented 2 years ago

code implementation done by @jacobwindsor. Waiting on content from @gabsie

jacobwindsor commented 2 years ago

https://github.com/ebi-ait/ingest-ui/pull/173

ESapenaVentura commented 2 years ago

@gabsie has a starter page - Working on this today

ESapenaVentura commented 1 year ago

Set up deadline for Friday 28th

gabsie commented 1 year ago

@ofanobilbao I am starting here, and we can continue working together here https://docs.google.com/document/d/1eIAsRIUmUtJaPgTMuFuHjMGCm3fhg0oefLfYeElZM-M/edit?usp=sharing I am also doing a visualisation also in Miro

idazucchi commented 1 year ago

gabs to send the first page for review today

gabsie commented 1 year ago

https://docs.google.com/document/d/1eIAsRIUmUtJaPgTMuFuHjMGCm3fhg0oefLfYeElZM-M/edit?usp=sharing

Wkt8 commented 1 year ago

@idazucchi and @Wkt8 to review this document. Oihane has reviewed.

gabsie commented 1 year ago

@amnonkhen - can you please look at the code etc using the example text from the doc? I will arrive on campus and continue catching up.

amnonkhen commented 1 year ago

@gabsie Here is what it looks like. What do you think? image.png

MightyAx commented 1 year ago

@Gabs to make minor visual changes.

gabsie commented 1 year ago

Hey Amnon In the file, I changed the subsections to have shorter names: https://docs.google.com/document/d/1eIAsRIUmUtJaPgTMuFuHjMGCm3fhg0oefLfYeElZM-M/edit?usp=sharing

MightyAx commented 1 year ago

submission guide has been deployed to dev for testing

ESapenaVentura commented 1 year ago

I have a couple of comments:

I can create a PR for the content changes, let me know!

ofanobilbao commented 1 year ago

This is now live in Dev. @gabsie will review the content and edit it. Amnon showed her how to be able to edit going forward

Wkt8 commented 1 year ago

Gabs to continue editing and then to create a PR for merging into prod / master. Alexie and Enrique to support if necessary.

MightyAx commented 1 year ago

deploying to staging

MightyAx commented 1 year ago

@gabsie

@MightyAx / @amnonkhen

gabsie commented 1 year ago

This is ready for Prod as far as I am concerned

idazucchi commented 1 year ago

alexie will push this to prod today

MightyAx commented 1 year ago