Open ofanobilbao opened 3 years ago
Overall I like the list included in the acceptance criteria.
The first part is alright for the examples, but the metadata terms
part I am not super convinced of. I do see some potential in people looking for specimen from organism
just searching for all the specimens, but I don't see anyone filling in full qualified keys to find anything (especially since you have to provide a value for the search to make sense, e.g. biomaterial_core.biomaterial_id
="blablabla")
I have made a recompilation of the list of fields that I would find useful to do searches on:
x.biomaterial_core.biomaterial_id
x.biomaterial_core.biomaterial_name
x.biomaterial_core.biosamples_accession
(Sometimes I might want to search by accessions)x.biomaterial_core.insdc_sample_accession
y.file_core.file_name
process.process_core.process_id
(Useful for library preps)z.protocol.protocol_core.protocol_id
z.protocol.protocol_core.protocol_name
process.insdc_experiment.insdc_experiment_accession
sequence_file.insdc_run_accessions.[]
project.contributors.[].name
project.contributors.[].project_role.label
Substituting:
x
by any biomaterial typey
by any file typez
by any protocol typeAnd also a list of fields that would also be nice to look for:
donor_organism.diseases.[].label
(or text)donor_organism.development_stage.label
(or text)specimen_from_organism.organ.label
specimen_from_organism.organ_parts.[].label
cell_suspension.selected_cell_types.[].label
So, tl;dr, this list applies to the first example in the terms on the acceptance criteria and, about the second, I would find useful to look for entity types, but not for specific fields
Initial Tasks:
hi everyone Issue #106 - is where I have placed some suggestions for discussion - for search within a project
@gabsie I see this as related to the Updates Quicker. Do we want to keep it or recreate the info we already have here? Things might have changed over the last year. Thoughts?
User story
As a wrangler/data contributor I want to "Locate the part of the project to be updated" so that I can correct mistakes with (meta)data for a project that is already in the DCP/Archives.
Wranglers /contributors will know the “target” they wish to update, but it must not be assumed that they will know the UUID of this entity. An intuitive and user-friendly mechanism for retrieval of target entities is therefore required (e.g. search by ID/name/accession within a submission).
This will be fulfilled by having search functionality on the project view page
Acceptance Criteria
search will be within the project being viewed user can search by a values in the metadata of a project return any results that match
*examples include metadata content such as - sample_0113, hypertension, left lung, SRX5692097, process_id_1
Ideally there will be "live searching" and autocomplete so user doesn't need to fully type all of a term (stretch goal)