ebi-ait / hca-ebi-dev-team

Repository for hca ebi dev team agile management. See zenhub board
0 stars 0 forks source link

[UI] Show Results of Archiving #98

Open MightyAx opened 4 years ago

MightyAx commented 4 years ago

UI should display the results of Archive Submission: Entities:

Submissions:

MightyAx commented 4 years ago

Caveat, since writing the ticket we have the concept of contributors and wranglers.

Wranglers should see the above. Contributors should only see accessions.

Planning Poker Estimate, since we will probably end up reviewing what it means for a contributor to see details a submission as part of this ticket: 13

aaclan-ebi commented 4 years ago

Some of the work to be able to store info about DSP Submission and its entities is already covered in #147. However the work to actually update those created entities with processing result/ accessions once archiving is completed is not implemented yet. The work for that can be added in this ticket.

aaclan-ebi commented 4 years ago

Update: Updating of archived entities with accessions was done on ticket #147

aaclan-ebi commented 4 years ago

An accessions tab was added in the submissions view for the demo last sprint. We can get feedback from that and work on improving it in this ticket.

lauraclarke commented 4 years ago

While I remember, I noticed on the ENA study you showed the ERP rather than the PR, was there a reason for that decision. I think ENA are at some point going to retire ERPs so it might be better to stick to the PR

aaclan-ebi commented 4 years ago

Hi @lauraclarke , it's the accession i got from DSP test env.

aaclan-ebi commented 4 years ago

Hmm looks like it's also the format of accession being returned in their prod env. Laurenti dataset study accession is ERP122459.

aaclan-ebi commented 4 years ago

slack convo: https://embl-ebi-ait.slack.com/archives/CNL3AH7BQ/p1593077602029600

if we want to show PRs, it could be easily retrieved from ENA API:

https://www.ebi.ac.uk/ena/portal/api/links/study?accession={secondary_accession}&format=json&result=study

[
  {
    "study_accession": "PRJEB36736",
    "description": "Single-cell transcriptional landscape of human embryonic limb development"
  }
] 

The study record can be retrieved either way so this is not a big issue atm. https://www.ebi.ac.uk/ena/data/view/PRJEB31843 https://www.ebi.ac.uk/ena/data/view/ERP114453