ebi-ait / hca-ebi-wrangler-central

This repo is for tracking work related to wrangling datasets for the HCA, associated tasks and for maintaining related documentation.
https://ebi-ait.github.io/hca-ebi-wrangler-central/
Apache License 2.0
7 stars 2 forks source link

GSE176201 - Covid19LungSequelae #1099

Closed ofanobilbao closed 1 year ago

ofanobilbao commented 1 year ago

Project short name:

Covid19LungSequelae

Primary Wrangler:

Ida

Secondary Wrangler:

Arsenios

Link to Ingest

https://contribute.data.humancellatlas.org/projects/detail?uuid=fae72d89-4ac4-4aab-9b93-574775e168d4&tab=project

Associated files

Published study links

Key Events

idazucchi commented 1 year ago

ready for secondary review!

arschat commented 1 year ago

Great submission, only two minor comments.

idazucchi commented 1 year ago

I've added the hca_bionetworks info by uploading a spreasheet to the existing submission the incovenient thing is I did it twice so this bit of metadata is repeated twice since the hca_bionetworks is loaded as an array - I think I can fix it with the api

ofanobilbao commented 1 year ago

@idazucchi will attempt with Enrique's guide. @arschat can help if needed as he did this a short while ago

ESapenaVentura commented 1 year ago

I have a feeling programmatic updates with POST requests delete the submissionDate - Please refrain from making them, use PATCH instead :)

This dataset is missing the project submissionDate as the other R28 error, so the actions are similar:

ESapenaVentura commented 1 year ago

Operational fixes for staging area

# Project metadata
gsutil cat gs://broad-dsp-monster-hca-prod-ebi-storage/prod/fae72d89-4ac4-4aab-9b93-574775e168d4/metadata/project/fae72d89-4ac4-4aab-9b93-574775e168d4_2023-05-18T14:16:29.973000Z.json | jq -jc '.provenance.submission_date = "2023-03-31T06:06:350Z"' > fae72d89-4ac4-4aab-9b93-574775e168d4_2023-05-18T14:16:29.973000Z.json
gsutil cp fae72d89-4ac4-4aab-9b93-574775e168d4_2023-05-18T14:16:29.973000Z.json gs://broad-dsp-monster-hca-prod-ebi-storage/prod/fae72d89-4ac4-4aab-9b93-574775e168d4/metadata/project/fae72d89-4ac4-4aab-9b93-574775e168d4_2023-05-18T14:16:29.973000Z.json

# Supplementary file metadata
gsutil cat gs://broad-dsp-monster-hca-prod-ebi-storage/prod/fae72d89-4ac4-4aab-9b93-574775e168d4/metadata/supplementary_file/25f32c01-fffb-5b75-a0fc-621313b0ba92_2023-05-18T16:53:24.450000Z.json | jq -jc '.provenance.submission_date = "2023-03-31T06:06:350Z"' > 25f32c01-fffb-5b75-a0fc-621313b0ba92_2023-05-18T16:53:24.450000Z.json
gsutil cp 25f32c01-fffb-5b75-a0fc-621313b0ba92_2023-05-18T16:53:24.450000Z.json gs://broad-dsp-monster-hca-prod-ebi-storage/prod/fae72d89-4ac4-4aab-9b93-574775e168d4/metadata/supplementary_file/25f32c01-fffb-5b75-a0fc-621313b0ba92_2023-05-18T16:53:24.450000Z.json
ofanobilbao commented 1 year ago

@ESapenaVentura to confirm if we still need to do the updates in Ingest. We submitted already the changes to DCP right?

ofanobilbao commented 1 year ago

If changes are done in ingest we would be able to close this ticket right?

ofanobilbao commented 1 year ago

@ESapenaVentura was this done as part of the Release 28 import errors that Amnon resolved last week? Or is this still pending and we need to flag it with Amnon?

idazucchi commented 1 year ago

missing submissionDate was add back to ingest by Amnon - this ticket can be closed!