ebi-ait / hca-ebi-wrangler-central

This repo is for tracking work related to wrangling datasets for the HCA, associated tasks and for maintaining related documentation.
https://ebi-ait.github.io/hca-ebi-wrangler-central/
Apache License 2.0
7 stars 2 forks source link

GSE134144 - TestisCellAtlas #167

Open ESapenaVentura opened 3 years ago

ESapenaVentura commented 3 years ago

Primary Wrangler: Enrique Secondary Wrangler: Ami

Associated files:

Google Drive: https://drive.google.com/drive/folders/1YuUwBnrDvx9ofzh6QDHR5yCyXzqs1ggN

Published study links

Paper: https://www.cell.com/cell-stem-cell/fulltext/S1934-5909(19)30523-5

Accessioned data: GSE134144

Key Events

rays22 commented 3 years ago

@ESapenaVentura : The metadata spreadsheet GSE134144_ontologies.xlsx has passed all the ingest-graph-validator tests without any errors. I am attaching links to two images. One graph is for the protocols and the other for the biomaterials.

ESapenaVentura commented 3 years ago

@ami-day will be the secondary wrangler when she has capacity

Ingest UI link

A couple of notes:

ami-day commented 3 years ago

@ESapenaVentura I have done the secondary review and made changes to a copy located here: https://docs.google.com/spreadsheets/d/1nVfbUfY_zzxZZHe4IuDb9OvZz6uhFXzP/edit#gid=385545271 I didn't make all the below changes as some require discussion.

In general the metadata looks very complete and accurate but here are some comments:

ESapenaVentura commented 3 years ago

Thanks @ami-day ! About the points:

ESapenaVentura commented 3 years ago

I have updated the spreadsheet and the submission in ingest!

A little note: I have changed the image file content descriptions, as the content description is an ontologised term (I have moved the description you provided to the file description field)

Once we get some info about the correct way to represent the sex of the transfemale donors, it should be good to go!

ami-day commented 3 years ago

Ok all sounds good!

I didn't think about being able to expand the ontology and I'm not sure exactly what you mean by this - do you mean, a user would check all the parent ontology terms for a given specific ontology ID? It does sound like extra work and I have never seen how this might be done during analyses e.g. if someone wanted to plot a graph or figure with development stage labels. I still think we should make the development stage more broad.

ESapenaVentura commented 3 years ago

What I mean is that (once implemented), they can search for "juvenile" and these samples would appear because they are children of juvenile! but they will also appear if they do a more specific search (e.g, 7 year old human).

This is still far off from being implemented but I feel like we should act as if it is because curating after that feature is in the browser search will be a huge headache!

I am happy to further discuss this if necessary though

ami-day commented 3 years ago

Yea that would be great if eventually it will be possible to search for projects in the data portal by an 'expanded' list related to an ontology search term. Hmm sounds complex to implement to me

ami-day commented 3 years ago

Outcome of group discussion:

ESapenaVentura commented 2 years ago

This ticket has a dependency on https://github.com/HumanCellAtlas/metadata-schema/issues/1409

ESapenaVentura commented 2 years ago

@ipediez put me in contact with someone from Prisma (A science LGBTQ+ association) to discuss about this.

We are currently discussing if the combination of Biological sex + Gender identity would accurately represent the spectrum of the human sexuality and gender identity

ami-day commented 2 years ago

This dataset is suitable for SCEA. @ESapenaVentura is this still blocked and not yet submitted to HCA DCP?

ESapenaVentura commented 2 years ago

This dataset is suitable for SCEA. @ESapenaVentura is this still blocked and not yet submitted to HCA DCP?

yes, we still don't have the schema update needed

ami-day commented 2 years ago

Assigned E-HCAD-55

ami-day commented 1 year ago

Need to ask Enrique if the final spreadsheet is available for curation and where it is.

ami-day commented 1 year ago

This dataset is already in the SCEA Data Browser. Accession: E-GEOD-134144

idazucchi commented 1 year ago

waiting for #844 enrique will add the matrices to the project

Wkt8 commented 1 year ago

Still waiting on the gender_ontology term