search

ebi-ait / hca-to-scea-tools

Helpers and tools to assist in the conversion of HCA datasets into SCEA
0 stars 0 forks source link

Feature/hcatoscea_test_data_ami_update #59

Closed ami-day closed 2 years ago

ami-day commented 2 years ago

Fixed input test files (TEST01.xlsx, TEST02.xlsx) which were resulting in incorrect output files. Updated the arguments.csv file to reflect this.

amnonkhen commented 2 years ago

These changes are correct and intended.

@ami-day I do not understand your comment.

ami-day commented 2 years ago

These changes are correct and intended.

@ami-day I do not understand your comment.

Hi @amnonkhen I'm not sure what I meant by this. I made the changes you suggested. Can this request be approved now?

ami-day commented 2 years ago

Thanks for updating the hca to scea test input spreadsheet. I do not, however, see the expected results files, namely the idf/sdrf files for each of the test cases? Before merging your changes, the tests should run successfully. At least for your test cases. You can run the tests on your environment by running python -munittest. Also, once you push them to the remote branch github runs them for you. Please examine the output, and fix the errors. If you don't undersatnd the error messages, talk to me.

Thanks @amnonkhen I have done this, the test is returning "OK" now.

ami-day commented 2 years ago

Closing this branch, it is an older version that is now out of date.