search

ebi-ait / ingest-graph-validator

HCA Ingest Service Graph Validation Suite
MIT License
1 stars 0 forks source link

20200514: edit sequence_file_linkto_cell_suspesion test #8

Closed mshadbolt closed 3 years ago

mshadbolt commented 4 years ago

Describe the issue

I noticed that there is a rule in the test set that says all sequence files should link to a cell suspension, but this is not a strict rule. I would ideally like this rule to throw and error with a summary that shows for which entities this is the case rather than failing validation. The specific project this is relevant for at the moment is the TissueSensitivity project but it is also possible that there could be more data in the future that would fail this test.

The specific test file is: graph_test_set/sequence_file_linkto_cell_suspesion.adoc

Acceptance criteria

mshadbolt commented 4 years ago

@ESapenaVentura had the idea to create a more complex version of the test where the test only runs if the input is single cell or single nuclei.

ESapenaVentura commented 3 years ago

This was addressed on PR https://github.com/ebi-ait/ingest-graph-validator/pull/34

Closing now!