ebi-gene-expression-group / atlas-components

Front end components of Expression Atlas and Single Cell Expression Atlas
3 stars 3 forks source link

📦 scxa-marker-gene-heatmap 💬 Feature #179903224, #179903243 – Add link to experiment accession labels and fix regression #115

Closed alfonsomunozpomer closed 2 years ago

alfonsomunozpomer commented 2 years ago

Besides linking the column label I noticed we inadvertently had put back the experiment accessions to the right of the multiexperiment cell type heatmap, when we shouldn’t have. The check heatmapType !== \cellmultiexperiment`was of course failing to match anything. Maybe we should keep track of this sort of hard-coded strings some other way, maybe usingObject.keys`, or some other way to avoid this type of mistakes (I suspect I changed the name in the provider and forgot to change it elsewhere).