search

ebi-gene-expression-group / atlas-components

Front end components of Expression Atlas and Single Cell Expression Atlas
3 stars 3 forks source link

Have the scatter plot component make requests to the new version of the JsonCellPlotController that accepts any value for plot type #121

Closed lingyun1010 closed 1 year ago

lingyun1010 commented 1 year ago

We need to change these two methods:

https://github.com/ebi-gene-expression-group/atlas-components/blob/9301396f596483e45946a16eb9c4cd7dd16e20af/packages/scxa-tsne-plot/src/TSnePlotView.js#L58

https://github.com/ebi-gene-expression-group/atlas-components/blob/9301396f596483e45946a16eb9c4cd7dd16e20af/packages/scxa-tsne-plot/src/TSnePlotView.js#L80

Do not process the URL text outside of URI (e.g. https://github.com/ebi-gene-expression-group/atlas-components/blob/9301396f596483e45946a16eb9c4cd7dd16e20af/packages/scxa-tsne-plot/src/TSnePlotView.js#L67), you must use URI’s API to create the URL and the last method should always be .toString().