📦 scxa-tsne-plot 💬 feature: Use default plot method and parameterisation from backend props - Githubissues

ebi-gene-expression-group / atlas-components

Front end components of Expression Atlas and Single Cell Expression Atlas

3 stars 3 forks source link

📦 scxa-tsne-plot 💬 feature: Use default plot method and parameterisation from backend props #134

Closed lingyun1010 closed 1 year ago

lingyun1010 commented 1 year ago

We need to change these two methods:

Do not process the URL text outside of URI (e.g. https://github.com/ebi-gene-expression-group/atlas-components/blob/9301396f596483e45946a16eb9c4cd7dd16e20af/packages/scxa-tsne-plot/src/TSnePlotView.js#L67), you must use URI’s API to create the URL and the last method should always be .toString().

The endpoint for default plotTypes is provided in the PR https://github.com/ebi-gene-expression-group/atlas-web-single-cell/pull/272. I am trying to update the frontend component to apply this feature.

lingyun1010 commented 1 year ago

@lingyun1010 can you please provide a brief description of what this PR is implementing/fixing? Also, please update your PR to use this formatting for the title so that it's a bit clearer which package is being changed in this PR (#113)

Yes. Thanks for the reminder. I updated it and please take a review.