search

ebi-gene-expression-group / atlas-components

Front end components of Expression Atlas and Single Cell Expression Atlas
3 stars 3 forks source link

📦 scxa-tsne-plot 💬 Fix tsne and umap format and default parameter #140

Closed lingyun1010 closed 1 year ago

lingyun1010 commented 1 year ago

We need to fix two things here:

  1. tsne and umap from cell plot endpoint changed to t-SNE and UMAP
  2. the default parameter and method props from experiment page endpoint is defaultPlotMethodAndParameterisation TODO: 3. Make the dropdown options dynamiclly rather than hard coded values for t-SNE or UMAP

Reviewer may test this PR under the latest postgres database.

upendrakumbham commented 1 year ago

@lingyun1010, I managed to install nvm and switch to node version 14. This resolved my front-end issue as you said before.

Here is the screenshot:

image

Alfonso help me in further debugging this issue and picking the right commit of atlas-web-core.

These endpoints still using old plot methods as data, and our demo page still contains old data. Could you please fix this data as per the latest plot method changes? Let me know once you finished.

Thanks

lingyun1010 commented 1 year ago

@lingyun1010, I managed to install nvm and switch to node version 14. This resolved my front-end issue as you said before.

Here is the screenshot:

image

Alfonso help me in further debugging this issue and picking the right commit of atlas-web-core.

These endpoints still using old plot methods as data, and our demo page still contains old data. Could you please fix this data as per the latest plot method changes? Let me know once you finished.

Thanks

You might test on a different branch. Screenshot 2023-06-28 at 10 43 55

upendrakumbham commented 1 year ago

Hi @lingyun1010, you're right I was using master branch for the testing. I switched to above branch and tested. All working fine after a small change in the demo.js. I have accesskey in my DB for the E-MTAB-5061 is, this one 7ff78b93-f081-4087-9bd3-abcff0ef0b60, but demo page has different one. Not sure which is correct one. Please verify from your end before merging, other wise all good. So I'm approving both PR's.