search

ebi-gene-expression-group / atlas-components

Front end components of Expression Atlas and Single Cell Expression Atlas
3 stars 3 forks source link

Bugfix/colour by category url logic 400 error #144

Closed lingyun1010 closed 11 months ago

lingyun1010 commented 11 months ago

I fix the logic in the url fetching stage, which is more straight forward, as the colourByCategory is decided by the vlaue of colourBy

lingyun1010 commented 11 months ago

I am missing a test for the code change. Could you please add it or please describe me why we don't need it? Thanks

I have looked into this issue. The true or false logic just change the value of a variable not affect any other props or state or UI staff, so we don't have a test for this.