search

ebi-gene-expression-group / atlas-heatmap

Heatmap visualizing bulk Expression Atlas data
8 stars 2 forks source link

Add a switch to the widget to disable the top menu #9

Closed wbazant closed 6 years ago

wbazant commented 6 years ago

Hello! We've restored the Atlas widget in WBPS. It currently looks as follows: test page.

The top menu seems like it could be useful for other projects but it isn't really doing anything for us - I've made a fork of the Atlas widget and added a feature of disabling it. Would you merge this change? I think it's potentially useful across projects.

I'd rather not maintain a fork long term if I can avoid it - if you don't like the switch as a feature would you consider adding a CSS class to the top menu - something like "gxaControlMenu" - so that we can style it with display:none?

alfonsomunozpomer commented 6 years ago

I can’t see anything wrong with the change in principle. Thanks for keeping up with the spirit of free software. ;) Will review and merge tomorrow.

Cheers!

wbazant commented 6 years ago

Any time! Do you like the name of the switch to be showControlMenu ? If you do and will eventually merge, we'll make the WBPS10 site call the widget with that, release it, then you'll release a new version and WBPS10 will incrementally improve, while we'll still be sourcing the bundles as built by you - which has avantages- but it is all optional, since we can also have a fork etc.