search

ebi-gene-expression-group / atlas-web-bulk

Bulk Expression Atlas web application
Apache License 2.0
0 stars 1 forks source link

Add a more sophisticated mechanism to link experiments #142

Closed lingyun1010 closed 1 year ago

lingyun1010 commented 2 years ago

In bulk experiment page, there are some experiments have alternative views, such as E-MTAB-5200 and E-MTAB-5423.

If the source and destination experiment types (according to accessions) are different, show link as Related <proteomics/transcriptomics> experiment, otherwise keep the current format (View by ).

Due to lacking good examples in local files, I tested experiment E-MTAB-5200 with an alternative view E-PROT-1 locally, as shown below:

Screenshot 2022-09-13 at 08 56 37

While normally it is View by individual, check below: https://www.ebi.ac.uk/gxa/experiments/E-MTAB-5200/Results

lingyun1010 commented 2 years ago

@haideriqbal The sister web core PR is https://github.com/ebi-gene-expression-group/atlas-web-core/pull/113.

haideriqbal commented 2 years ago

@haideriqbal The sister web core PR is ebi-gene-expression-group/atlas-web-core#113.

@lingyun1010 please look into this branch and rebase/update it accordingly, because it contains quite a few changes in web-core which are not mentioned in your atlas-web-core PR. I assume this branch needs to be updated to properly reflect the changes you made in atlas-web-core.

alfonsomunozpomer commented 2 years ago

@lingyun1010 @haideriqbal Can’t you see something that can be clearly improved in the screenshot?

haideriqbal commented 2 years ago

@lingyun1010 @haideriqbal Can’t you see something that can be clearly improved in the screenshot?

The experiment type is being displayed in the label which the user would not be able to make sense of. PROTEOMICS_BASELINE_DIA should be transformed into Proteomics.

lingyun1010 commented 2 years ago

@lingyun1010 @haideriqbal Can’t you see something that can be clearly improved in the screenshot?

Okay I see, then maybe the humanDescription defined in ExperimentType will work? In this case, it would be Proteomics baseline DIA.