ebi-gene-expression-group / atlas-web-bulk

Bulk Expression Atlas web application
Apache License 2.0
0 stars 1 forks source link

Missing alternate view of an experiment crashing the start up of our web apps #177

Closed ke4 closed 7 months ago

ke4 commented 9 months ago

Currently if an experiment has an alternative view defined in its factor.xml file and that other experiment is missing from the database, then our application stops when we try to start up the application and it is processing that experiment. This is happening both in single cell and bulk as the logic is shared.

We have to replace this logic and implement the following if there is a missing alternative view:

  1. Log it with an error status that the alternative view is missing from the database
  2. Send a notification to the developers/data prod team about the above fact
  3. The application loading should continue without processing the alternative view of that expariment
ke4 commented 9 months ago

Here lies the code that we have to refactor: https://github.com/ebi-gene-expression-group/atlas-web-core/blob/2dcf1d8e0e19f58be6971a3f642a50e2da3c1023/src/main/java/uk/ac/ebi/atlas/trader/factory/BaselineExperimentFactory.java#L80

extractAlternativeViews(String experimentAccession, BaselineExperimentConfiguration factorsConfig)