[Bugfix] Update codebase to latest atlas-web-core module

ebi-gene-expression-group / atlas-web-bulk

Bulk Expression Atlas web application

Apache License 2.0

0 stars 1 forks source link

[Bugfix] Update codebase to latest atlas-web-core module #180

Closed ke4 closed 5 months ago

ke4 commented 5 months ago

Changes / bug fixes:

Fix test runner scripts
Add ontology related files to our local Docker env
Remove large experiments from local env
Implement ExperimentCellCountDao interface
Remove experiment design tab from the experiment page
Fix failing tests
Add E-MTAB-5555 as a private experiment
Add new section to the README: How to add a private experiment into our local env

Related PR in atlas-web-core: https://github.com/ebi-gene-expression-group/atlas-web-core/pull/134

lingyun1010 commented 5 months ago

All good for me!

upendrakumbham commented 5 months ago

Looks like there is a bug in this PR: My application is up and running, so I was testing this branch, I knew that it was approved by Lingyun and merged.

upendrakumbham commented 5 months ago

The home page search got broken in my local application. Example terms are not working for any/any species. But if I choose home sapiens species and search the term 'lung', hit search. I can see the result for this case.

upendrakumbham commented 5 months ago

All tests got passed

ke4 commented 5 months ago

Looks like there is a bug in this PR: My application is up and running, so I was testing this branch, I knew that it was approved by Lingyun and merged.

@upendrakumbham Thanks for this finding. TBH I am not sure what is going on. On staging this search is working. I just tested locally the very same WAR file that has been deployed to staging and it is producing the same error locally. Maybe something missing from our local setup??? I have no idea. Next step for me to deploy the next version with the alternative view fix 1st to test env and not directly to staging and check if we have that error there, too.