ebi-gene-expression-group / atlas-web-single-cell

Single Cell Expression Atlas web application
Apache License 2.0
5 stars 5 forks source link

Feature/181713000 pick the default plot type and parameter values from the backend #272

Closed upendrakumbham closed 1 year ago

upendrakumbham commented 2 years ago

Ann data feature:

Note: This story has a dependency - we need to merge this PR once we merge migrate-to-schema-v19. Otherwise, Jenkins build will break due to legacy code with latest schema.

Here is the final output : {umap={"n_neighbors":15}, tsne={"perplexity":20}}

upendrakumbham commented 2 years ago

Hi @lingyun1010, I have fixed your review comments, please have a look.

lingyun1010 commented 1 year ago

The default plot method and parameterisation could be passed into the tsne plot component as part of the content in ExperimentPageContentService, so please consider if we still need an endpoint for that.

lingyun1010 commented 1 year ago

Please also keep the json reponse as the format like defaultPlotTypeAndParameterisation: {"t-SNE": {"perplexity": 50}, "UMAP": {"n_neighbors": 100}}, the same as the props plotTypesAndOptions, so we could have consistent parsing method in the front-end. FYI, currently the json reponse from the endpoint is {"t-SNE":"{\"perplexity\": 50}","UMAP":"{\"n_neighbors\": 100}"}.