search

ebi-gene-expression-group / atlas-web-single-cell

Single Cell Expression Atlas web application
Apache License 2.0
5 stars 5 forks source link

Chore – Remove experiment design #316

Closed alfonsomunozpomer closed 1 year ago

alfonsomunozpomer commented 1 year ago

The Experiment Design tab in the controller has been removed. Other than that, the big changes in this PR are in atlas-web-core.

Accompanied by https://github.com/ebi-gene-expression-group/atlas-web-core/pull/121.

alfonsomunozpomer commented 1 year ago

One quick question - why are we not deleting this code

public JsonObject getExperimentDesign(String experimentAccession,
                                         JsonObject experimentDesignTableAsJson,
                                         String accessKey) {
       var result = new JsonObject();

       result.add("table", experimentDesignTableAsJson);

from the ExperimentPageContentService class. Any reason to keep it?

Good catch. No, no reason at all. I’ve deleted it now.