search

ebi-gene-expression-group / atlas-web-single-cell

Single Cell Expression Atlas web application
Apache License 2.0
5 stars 5 forks source link

Fix default plot type and it's parameterisation null check code issues #341

Closed upendrakumbham closed 10 months ago

upendrakumbham commented 1 year ago

Fixed a few code issues:

  1. Added a check in the getMiddleElement(List plotOptions) method
  2. Removed hardcoded cell plot methods in the method fetchDefaultPlotMethodWithParameterisation(String experimentAccession)
alfonsomunozpomer commented 1 year ago

Please add tests!

upendrakumbham commented 1 year ago

Please add tests!

We have tests for this @alfonsomunozpomer, positive and negative tests. Are you expecting any specific case like NullPointerException coverage for the code you mean?

upendrakumbham commented 1 year ago

Let's chat on this after standup to add more test coverage.