ebi-gene-expression-group / atlas-web-single-cell

Single Cell Expression Atlas web application
Apache License 2.0
5 stars 5 forks source link

Enable atlas-web-core integration tests in Single Cell Expression Atlas Gradle container #346

Closed alfonsomunozpomer closed 1 year ago

alfonsomunozpomer commented 1 year ago

We’ll need magetab and experiment designs for bulk, possibly Solr, too. This could make the execute-all-tests.sh script obsolete.

Summary of changes to the prepare-dev-environment directory:

For the Compose files that we use to launch and test the application:

This is all as a result of the need to parameterise all the YAML files with PROJECT_NAME to dynamically change between gxa and scxa. It was a massive tangent. The positive side of this is that we may be able to use exactly the same files for bulk and SC, but this needs some consideration.

There are some additional changes to test classes and a few other main classes in atlas-web-core, too. See https://github.com/ebi-gene-expression-group/atlas-web-core/pull/128.

Remember that this PR makes it possible to run integration tests for atlas-web-core locally with Docker. Jenkins doesn’t do that, because we don’t have a bulk CI environemnt yet. One exmple output of execute-all-tests.sh after adding integration tests in atlas-web-core is here: https://gist.github.com/alfonsomunozpomer/61ec9437124d93e672307813ad596b61

alfonsomunozpomer commented 1 year ago

@ke4 Please have another look. You were right and variables that are in --env-file aren’t necessary to be declared another time in the Docker Compose YAML files.

alfonsomunozpomer commented 1 year ago

@ke4 I addressed or otherwise clarified the issues you raised. Feel free to resolve the conversations or comment further.

alfonsomunozpomer commented 1 year ago

@ke4 There’s bin an extra bit of drama related to how --env-file isn’t exactly the same as env_file or using .env by default. Docker Compose is kind of weird... Have one more look at the last commit, please.