search

ebi-gene-expression-group / atlas-web-single-cell

Single Cell Expression Atlas web application
Apache License 2.0
5 stars 5 forks source link

Add url decoder for cell type heatmap search #355

Closed lingyun1010 closed 10 months ago

lingyun1010 commented 11 months ago

I deal with the / character in cell type value in the json endpoint as a request parameter

alfonsomunozpomer commented 11 months ago

Tests, please.

alfonsomunozpomer commented 11 months ago

Besides this, do we need to change any config files in Tomcat? If that’s the case, could you add the modified file to the docker directory, similar to the tomcat-users.xml file?

ke4 commented 11 months ago

Besides this, do we need to change any config files in Tomcat? If that’s the case, could you add the modified file to the docker directory, similar to the tomcat-users.xml file?

@alfonsomunozpomer I am not sure what you mean. The controller is getting an URL encoded parameter and it is encoding it. I think that is all. Did I miss something?

ke4 commented 11 months ago

@alfonsomunozpomer I added a test case for the case when the cell type parameter is containing a forward slash. Also improved the other tests (naming and missing assertions). Could you have another looks, please? Thanks

alfonsomunozpomer commented 10 months ago

Besides this, do we need to change any config files in Tomcat? If that’s the case, could you add the modified file to the docker directory, similar to the tomcat-users.xml file?

@alfonsomunozpomer I am not sure what you mean. The controller is getting an URL encoded parameter and it is encoding it. I think that is all. Did I miss something?

I remember that @lingyun1010 mentioned that maybe we needed to modify Tomcat’s configuration to encode forward slashes. If you think about it we only want to encode forward slashes in one path segment, and that might be problematic. Maybe it’s not and React Router can do that. Whatever the case it should be in a different PR.