Add consistency between cell plots tab and marker genes tab

ebi-gene-expression-group / atlas-web-single-cell

Single Cell Expression Atlas web application

Apache License 2.0

5 stars 5 forks source link

Add consistency between cell plots tab and marker genes tab #388

Closed lingyun1010 closed 2 months ago

lingyun1010 commented 3 months ago

According to Silvie's detailed comments, I add logics to make cell plot & marker gene plot options are consistent when the plot type is clusters.

Besides, I refactored the tab name from tsne to cell-plots as discussed in some meetings before, so the tab refers to both tsne and umap plots more properly.

ke4 commented 3 months ago

Your latest modification improved the code a bit, but we could do much more with it. I was thinking on this a bit, and I TBH it is going to be easier if I am going to sit down with you and show you how to clean this code. We can do it tomorrow if you are going to be in the Campus. It will only take a couple of minutes to show you and after that probably 10-15 minutes of your time to make the code prettier. Thanks