search

ebi-gene-expression-group / atlas-web-single-cell

Single Cell Expression Atlas web application
Apache License 2.0
5 stars 5 forks source link

Integrate scxa-faceted-search-result to move the anndata icon to the title column #405

Closed lingyun1010 closed 1 month ago

lingyun1010 commented 1 month ago

I published a new version of @ebi-gene-expression-group/scxa-faceted-search-results package and install in the backend bundles.

The design of experiment card and title column are not part of the package actually to make the component more generally useful, so we need to update ExperimentsCard.js and ExperimentHeader.js correspondingly as implemented in the atlas-components

ke4 commented 1 month ago

@lingyun1010 There is a NPE in the failed test case:

java.lang.NullPointerException
    at uk.ac.ebi.atlas.solr.SingleCellSolrUtils.lambda$getRandomCellTypesFromQueryResult$0(SingleCellSolrUtils.java:62)
    at java.base/java.util.stream.IntPipeline$1$1.accept(IntPipeline.java:180)
    at java.base/java.util.Spliterators$IntArraySpliterator.forEachRemaining(Spliterators.java:1032)
    at java.base/java.util.Spliterator$OfInt.forEachRemaining(Spliterator.java:699)
    at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
    at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
    at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913)
    at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
    at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578)
    at uk.ac.ebi.atlas.solr.SingleCellSolrUtils.getRandomCellTypesFromQueryResult(SingleCellSolrUtils.java:63)
    at uk.ac.ebi.atlas.solr.SingleCellSolrUtils.fetchedRandomCellTypesByCellIDs(SingleCellSolrUtils.java:37)
    at uk.ac.ebi.atlas.search.organismpart.OrganismPartSearchDaoIT.whenValidCellIdsAndValidCellTypesProvidedReturnSetOfOrganismPart(OrganismPartSearchDaoIT.java:120)

Maybe we should create a separate ticket and fix it separately. For this PR, maybe just try another build with Jenkins, but add the above ticket to the backlog, please.