ebi-gene-expression-group / atlas-web-single-cell

Single Cell Expression Atlas web application
Apache License 2.0
5 stars 5 forks source link

Revert buggy experiment design table changes in SCXA in develop #408

Closed ke4 closed 1 month ago

ke4 commented 1 month ago

We have a working hotfix branch: https://github.com/ebi-gene-expression-group/atlas-web-single-cell/tree/hotfix/test_without_exp_design_changes We need to merge it into develop to have a working/deployable develop branch.

ke4 commented 1 month ago

These are the 2 atlas-web-core submodule that we wanted to merge:

ke4 commented 1 month ago

It looks like the main problem is in this commit: [Bugfix] Update codebase to latest web core ( in this line: https://github.com/ebi-gene-expression-group/atlas-web-core/blob/ea4ce65ab9267101ba3390843221604fc6948a96/src/main/java/uk/ac/ebi/atlas/model/experiment/Experiment.java#L37

The added experimentDesign field for the Experiment entity is hugely increasing the memory usage when we load the experiments into the cache. I added that change to put back experiment design tab to Bulk Expression Atlas. That was clearly a wrong solution considering this is breaking Single Cell expression Atlas as the Experiment entity is commonly used in both.

We need to create a separate ticket and find a solution for this important issue as soon as possible.

ke4 commented 1 month ago

I realised that we have already created a ticket for this issue: https://github.com/ebi-gene-expression-group/atlas-web-bulk/pull/151, but that is an earlier issue for the same solution. Here is the ticket for the current issue: Adding experiment design as a field to Experiment entity cause a memory issue I am going to close this ticket - as it has been opened for a merge of 2 branches and not for the fix for the original issue.