Open ke4 opened 3 weeks ago
During my investigation, I found that we are supporting from the backend - but we are not passing species param from the frontend I believe as per the code:
@GetMapping(value = "/json/cell-type-wheel/{searchTerm}",
produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
public String jsonCellTypeWheel(@PathVariable String searchTerm,
@RequestParam(name = "species", defaultValue = "") String species) {
return GSON.toJson(
highchartsSunburstAdapter
.getCellTypeWheelSunburst(searchTerm, cellTypeWheelService.search(searchTerm, species)));
}
In the Atlas components repo - file name - CellTypeWheelExperimentHeatmap.js
<CellTypeWheelFetchLoader
host={props.host}
resource={URI(props.searchTerm, props.cellTypeWheelResource).toString()}
fulfilledPayloadProvider={cellTypeWheelData => ({ data: cellTypeWheelData })}
searchTerm={props.searchTerm}
onCellTypeWheelClick={onCellTypeWheelClick}
/>
I believe we need to pass species here from the dropdown when user chooses a species along with search term
Bugs we observed for now related to cell type wheel gene expression page:
From home page to cell type wheel page, species
is not passed by routing/URL.
In the cell type wheel page
Search boxes
species
box is not always working: it is not working when you change the species alone but is working when you change the species and then followed by search term changessearch term
box is not always working: when you select from user free typing section, for example liver
, no cell type data responded; when you select from metadata section, search button is not trigerring any requests.Cell type wheel
species
parameter from the search boxhomo sapiens
, it doesn't display by giving info like no data to display
homo sapiens
, the cell type wheel is not working by clicking to show the marker gene heatmap view.Endpoint issue
Based on the previous comment by @lingyun1010 I created the following separate tickets:
and we already had this ticket:
I won't delete the above comment, just to have it if we need it, but that comment does not belong to this current ticket.
The
Species
filter in the metadata search is getting ignored.Steps to reproduce:
Search term
box. For example:liver
Search
buttonSpecies
from the dropdown, for example:Mus musculus
Expected result: The cell type wheel only shows the result for the selected species.
Actual result: The cell type wheel shows the result for all the species.