search

ebi-gene-expression-group / atlas-web-single-cell

Single Cell Expression Atlas web application
Apache License 2.0
5 stars 5 forks source link

Decouple the experiment type with external links #427

Open lingyun1010 opened 3 weeks ago

lingyun1010 commented 3 weeks ago

This is a related PR for https://github.com/ebi-gene-expression-group/atlas-web-core/pull/144. The detailed rules are given by Silvie stated in the related issue. https://github.com/ebi-gene-expression-group/atlas-web-bulk/issues/195

lingyun1010 commented 1 week ago

@lingyun1010 It looks like the version of atlas-web-core you are using in this PR points into your branch, but that branch is not based on the latest version of atlas-web-core. That's why you had to do your last commit and that commit is totally go against the latest changes related to experiment design. Please fix that problem first, then I am going to review your other changes! Thanks

I rebase my atlas-web-core PR on atlas-web-core develop branch, but there is still conflicts in the github checks, as my atlas-web-single-cell PR is pointing to a new commit in atlas-web-core anyway, so I rebase this single-cell PR on atlas-web-single-cell develop branch again to resolve the conflicts. I will do the same for bulk PR too.